yuliskov / SmartTube

SmartTube - an advanced player for set-top boxes and tvs running Android OS
https://www.patreon.com/smarttube
Other
19.96k stars 1.07k forks source link

[Feature Request]: Expose (group) channels to ATV Home Launcher. #3959

Open subdancer opened 1 month ago

subdancer commented 1 month ago

Describe the feature you'd like to request

At the moment smarttube exposes 3 channels to the Android TV Home Launcher.

Subscriptions -> updateOrPublishChannel(mService.getSubscriptionsPlaylist()); Home -> updateOrPublishChannel(mService.getRecommendedPlaylist()); History -> updateOrPublishChannel(mService.getHistoryPlaylist());

Being able to add the newly added group channels will make the Android TV Home Launcher/Homescreen way more customised and neat.

Describe the solution you'd like

Update the functions updateChannels(); updateRecommendations(); in https://github.com/yuliskov/SmartTube/blob/bc005d3f27ea70947130c9537ca20bbacdecf9d2/leanbackassistant/src/main/java/com/liskovsoft/leanbackassistant/channels/UpdateChannelsTask.java#L30-L65 to expose the newly introduced group channels to the android tv home launcher.

Describe alternatives you've considered

Or maybe expose all channels that got pinned to smarttubes sidebar. Guess this will include group channels and also give the option that the user can have its favourite channels directly on the home screen when the device gets turned on. I'm not sure if this is easy to implement or a big task.

pucknbass commented 1 month ago

those already all work dunno what you are trying to say here .... i can see smartube suggestion and subscription on all launchers on all my different google tv / android tv device ... stock or third party launcher

subdancer commented 1 month ago

Yes we are able to select 3 channels (History, Recommended and Subscriptions) on the android tv launcher as feeds, that is all. Sorry for my bad english, but what i'm trying to communicate is that it would be great to have more than those 3 standard channels. Basicly all channels that get added to smarttubes sidebar.

Here are some pictures to explain further... In this one we can see that the latest codebase of smarttube exposes only 3 Channels to the ATV Launcher: Screenshot_20241002
Those are:
![Screenshot_20241002_222650](https://github.com/user-attachments/assets/9f279065-9912-422b-90a4-48d737f99cb0)
_222627 Screenshot_20241002_222650

I have added 2 channels to my smarttube sidebar on the left side as an example (see picture below). Kartonok and another channel called Irnoy :D. The latter is a new feature that just got implemented called group channels. Basicly a channel that holds a selection of channels (PS. being able to add a custom icon or symbol for the group channels would nice too but it's a feature that just got added in the latest release, so no rush). Screenshot_20241002_221405

I want those 2 channels (Kartonok and the group channel called Irony) to show up in the channel selection of the android launcher. basicly over here: Screenshot_20241002_222650 That would give us the power to get rid of the standard channels if we want and make custom ones for the homescreen =) For example a group channel called music, that holds only a selection of musicians or a channel called Cooking that holds ones favourite chef channels.

In my opinion this would be an awesome feature, because we would be able to customize the android tv homescreen with channels that hold content we actually care about and we will see news about them right when we turn on the device. I hope this clears up any missunderstandings. :bulb:

pucknbass commented 1 month ago

those are youtube API depedent not smartube so up to youtube to make more available to the tv recommendation service

tkhr123 commented 1 month ago

Hello, could you tell me which version of Android TV Home you're using? I noticed yours doesn't have any ads from Google, which I hate.

subdancer commented 1 month ago

those are youtube API depedent not smartube so up to youtube to make more available to the tv recommendation service

@pucknbass I'm not talking about modifying yt's channels. This is not even about yt.. Simply another missunderstanding.

If one writes an app and aggregates a list of (video) content be it external or internal and adds it to a channel builder, one is able to provide that channel to the homescreen (to any launcher that supports channels). The user will then be able to select and add that channel to the launcher. See here: https://developer.android.com/training/tv/discovery/recommendations-channel?hl=en#app_channels In my oponion auto picking those that get added to the st's sidebar would be a neat solution, because that way only those that the user actually cares about will be available.

@tkhr123 sure atv