search

yuliskov / SmartTubeLegacy

Watch YouTube videos on your TV and set-top-box with comfort
Mozilla Public License 2.0
4.41k stars 600 forks source link

Add support for SponsorBlock #314

Open neeez opened 4 years ago

neeez commented 4 years ago

SponsorBlock: https://github.com/ajayyy/SponsorBlock is a cool project that allows people watching YouTube to skip sponsorships via crowdsourced timestamps.

It'd be nice if SmartYouTube was able to skip sponsorships based on the database that is available.

rodalpho commented 4 years ago

This would be amazing!

seniorm0ment commented 4 years ago

+1 for this

NytronX commented 4 years ago

For the love of God, please add this feature. This feature would be more significant than any single current feature in the app now.

rix1337 commented 4 years ago

This should be quite straightforward. All it requires is a request to their API (https://github.com/ajayyy/SponsorBlock/wiki/API-Docs) at /api/skipSegments which responds with a float[] containing start and endpoints of sponsor sections. These need to be passed onto the player to skip over.

rodalpho commented 4 years ago

Sponsorblock works extremely well in the browser, it would be incredible to get it on my TVs too.

Edit: Oh I see from issue 483 that Yuriy doesn't want to do it. Must be difficult to add. Oh well.

ajayyy commented 4 years ago

By the way, @siku2 made a Kodi plugin: https://github.com/siku2/script.service.sponsorblock

rodalpho commented 4 years ago

Thanks for sponsorblock, Ajayyy! Love it, use it every day, just not sadly on my TV.

I do have the kodi YT addon configured but strongly prefer Yuriy's SmartYouTubeTV on my TV.

rix1337 commented 4 years ago

The original dev is implementing this in NewPipe. https://github.com/TeamNewPipe/NewPipe/pull/3205

Maybe @polymorphicshade could help us out on the TV side as well!

rodalpho commented 4 years ago

Ajayyy is the sponsorblock dev, the newpipe integration is being built by someone else. But yeah, that will be cool.

Newpipe actually supports the 10' androidTV UI as of like a month ago. I tried it out and really didn't like it though. The original YouTube UI (as seen in SYTV also) is far superior, with the Kodi UI coming in second. Just my personal opinion.

AntoineTA commented 3 years ago

+1. Nowadays, sponsorblock is probably as relevant as a standard ad blocking filter, since so many creators use integrated ads.

rix1337 commented 3 years ago

Vanced has just added it to their stable .. https://www.reddit.com/r/Vanced/comments/iepmo1/release_153334/

EDiT: Here is their implementation of SponsorBlock https://github.com/YTVanced/SponsorBlock

fawzib commented 3 years ago

i vote for this as a priority. soon sponsorblock will be a standard api in all applications that uses youtube

ACiDxCHRiST commented 3 years ago

I absolutely agree with AntoineTA. These days, SponsorBlock is almost as important as standard ad blocking. @yuliskov, please reconsider implementing the SponsorBlock API in SmartYouTubeTV.

I have been using SponsorBlock for the past 2 weeks on PC (via browser extension) and phone (via Vanced) and it drastically improves the experience over just standard ad blocking.

kirilldem commented 3 years ago

Also a vote from me, would make the app perfect!

rodalpho commented 3 years ago

Yuriy already replied and said he didn't want to do it. SYTV is open-source, if anyone has the coding chops I'm sure he'd accept a PR.

rgbg2498 commented 3 years ago

SponsorBlock: https://github.com/ajayyy/SponsorBlock es un proyecto genial que permite a las personas que ven YouTube omitir los patrocinios a través de marcas de tiempo de colaboración colectiva .

Sería bueno si SmartYouTube pudiera omitir los patrocinios en función de la base de datos disponible.