search

yuliskov / SmartTubeLegacy

Watch YouTube videos on your TV and set-top-box with comfort
Mozilla Public License 2.0
4.42k stars 598 forks source link

Keycode for invoking voice search has changed. Is this intended? #628

Open y-lee opened 4 years ago

y-lee commented 4 years ago

Version: 6.17.715 (Pro Alt) 320 dpi Device: SHIELD Android TV (darcy)

In .697 and previous versions, KEYCODE_SEARCH (Android key code 84) invoked in-app voice search. In .715 the keycode does nothing; however, KEYCODE_VOICE_ASSIST (Android key code 231) now invokes in-app voice search.

While having my remote control and Button Mapper send 231 instead of 84 is not a problem, this breaks compatibility with other apps that use KEYCODE_SEARCH to bring up search, such as Plex, PBS, and VLC.

yuliskov commented 4 years ago

Hmm. Strange. I suppose that both codes should work.

Regards, Yuriy

On Fri, Aug 21, 2020, 13:02 Yeechang Lee notifications@github.com wrote:

Version: 6.17.715 (Pro Alt) 320 dpi Device: SHIELD Android TV (darcy)

In .697 and previous versions, KEYCODE_SEARCH (Android key code 84) invoked in-app voice search. In .715 the keycode does nothing; however, KEYCODE_VOICE_ASSIST (Android key code 231) now invokes in-app voice search.

While having my remote control and Button Mapper send 231 instead of 84 is not a problem, this breaks compatibility with other apps that use KEYCODE_SEARCH to bring up search, such as Plex, PBS, and VLC.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/yuliskov/SmartYouTubeTV/issues/628, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABM7Z6GH5FYCP5ONTS4VZQDSBZA25ANCNFSM4QHDXGPA .

yuliskov commented 4 years ago

Sorry. Seems, that it's my fault. Will be fixed soon.

Regards, Yuriy

On Fri, Aug 21, 2020, 13:10 Yuriy Liskov firsthash@gmail.com wrote:

Hmm. Strange. I suppose that both codes should work.

Regards, Yuriy

On Fri, Aug 21, 2020, 13:02 Yeechang Lee notifications@github.com wrote:

Version: 6.17.715 (Pro Alt) 320 dpi Device: SHIELD Android TV (darcy)

In .697 and previous versions, KEYCODE_SEARCH (Android key code 84) invoked in-app voice search. In .715 the keycode does nothing; however, KEYCODE_VOICE_ASSIST (Android key code 231) now invokes in-app voice search.

While having my remote control and Button Mapper send 231 instead of 84 is not a problem, this breaks compatibility with other apps that use KEYCODE_SEARCH to bring up search, such as Plex, PBS, and VLC.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/yuliskov/SmartYouTubeTV/issues/628, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABM7Z6GH5FYCP5ONTS4VZQDSBZA25ANCNFSM4QHDXGPA .

y-lee commented 4 years ago

Much appreciated! While I have your attention, may I express hope that you look at #606 when you have time?

y-lee commented 4 years ago

.716 confirmed to voice search with both KEYCODE_SEARCH and KEYCODE_VOICE_ASSIST. Thank you for the quick response!