yuliskov / SmartTubeLegacy

Watch YouTube videos on your TV and set-top-box with comfort
Mozilla Public License 2.0
4.43k stars 599 forks source link

Pause button no longer works #715

Open Pa495 opened 4 years ago

Pa495 commented 4 years ago

Since update I can no longer pause any YouTube videos And also need to hit the back button twice to get out of a video

josesa commented 4 years ago

Also seeing this. Using the Play/Pause button on a FireTV 4K does nothing since the latest release.

htbhub commented 4 years ago

Same! Center button still pauses but my muscle memory keeps pressing pause button

bootythunder commented 4 years ago

Same - pause button doesn't work on Nvidia Shield Pro (2019). Also the back/forward buttons don't work. Bluetooth headset - pause, forward and back don't work either. The circle button on the Nvidia remote still works to pause and the left/right circle works for back/forward. But, like htb723 says - my muscle memory keeps pressing pause button.

Staubgeborener commented 3 years ago

Problem is still not solved. @yuliskov

Staubgeborener commented 3 years ago

I feel like not much is happening here. @yuliskov keeps referring to SmartTubeNext everytime.

But SmartTubeNext is extremely buggy (SmartYouTubeTV not) and videos have the loading animation twice and even then do not play.

Instead, this app does everything you need - if only there would be no problem with the play/pause button. So if only that could be fixed as the last commit for this repository (it's certainly only a line or two, since everything still worked in a commit from august and hardly anything has happened in the code since then) it would be just fine. After that, the repo can be put on hold.

For my part, I've looked through the last 20 commits and don't see the error. But i guess, it's somewhere here. Last two releases v6.17.725, v6.17.728 has this problem, v6.17.724 can not be checked, 'cause video don't play with this version (i only get a "loading"-message). Perhaps one of you (@Pa495 @josesa @htb723 @bootythunder) has recognized the problem here, then we could fork the project, fix the problem and compile our own apk (+ comment out the AppStateWatcher/ApkUpdaterHandler). Because besides this one problem, the project is magnificent.

Edit: Just reinstalled SmartYouTubeTV on my Fire TV 4k with the latest release 6.17.728 and i get a notification:

update to a new version 6.17.730 Pro: music video fix.

This one is not yet listed at the release page. This is not a fix for the play/pause button, but there is hope.

Edit 2: Nope, thats not a fix, still problems with play/pause. And i don't get the release procedure, the latest version on Github is v6.17.728, but @yuliskov uploaded v6.17.730 only on apklinker.

Edit 3: Even if I do self-talk here. It's working. There was no new commit. I just tested wolf launcher. Play/Pause button works there. I switched back to default launcher. Also there everything works fine. Well...

Edit 4: Nope, didn't work. I don't know where's the difference from now to yesterday, but Problem still exists @yuliskov

Excalibur212 commented 3 years ago

Why has the developer not responded here at all??? SmartYoutube is now useless on FireTV....can't use without pause as I mostly use to watch instructional videos. :-(

Can someone please tell me how to download the older working version to my FireTV using Downloader, or post it somewhere with download/install instructions?

Staubgeborener commented 3 years ago

@Excalibur212 Well, @yuliskov seems not be very interested in fixing SmartYouTubeTV because there is already a successor (in my opinion much worse and more buggy as this one). Also no one in this thread seems to be interested about fixing this on our own. Just google for older version of SmartYouTubeTV like "SmartYouTubeTV version 6.17.586" or so. You can download nearly any .apk-file with Downloader the same way you did it before. My experience: The older version want to force you to update to this buggy version. Every time you start the application.

saburch commented 3 years ago

For Sony Bravia TVs it's the same. The play/pause button does not work at all.

josesa commented 3 years ago

Ok, so I never built an android app before and have no clue about Android development but yesterday and today I spent a bit of time and hammered it enough to get some builds.

So my notes: I have 2 FireTV:

I noticed the pause button not working when I migrated to the 4K a few months back.

So today I got the old FireTV working and noticed that the pause button works even in latest versions. Also noticed that the UI was a bit different when the video was paused (weird that I didn't notice it before), so I wonder if there is actually a different mode activated.

Anyway, with being able to build the project locally and git bisect in hand I started to explore when the button stopped working.

0e4a55db bump to 6.17.721.    git bisect good
8b0ff83b bump to 6.17.722     git bisect good
fe8824bc bump to 6.17.724     git bisect good
39eaae4b def launcher         git bisect bad
12faa148 multi account: final git bisect good

39eaae4bf60a89e29f7ea0a6489010f8d31efc49 is the first bad commit
commit 39eaae4bf60a89e29f7ea0a6489010f8d31efc49
Author: Yuriy Liskov <firsthash@gmail.com>
Date:   Thu Nov 12 20:26:18 2020 +0200

    def launcher

 MediaServiceCore                                   |  2 +-
 SharedModules                                      |  2 +-
 smartyoutubetv/build.gradle                        |  4 ++--
 .../bootstrap/BootstrapActivity.java               |  6 ++---
 .../main/res/layout/bootstrap_launchers_row.xml    | 28 +++++++++++-----------
 5 files changed, 21 insertions(+), 21 deletions(-)

So something in 39eaae4b broke the button.

Unfortunately is also a release where the back button needs to be pressed multiple times to actually jump between windows so not sure if I will stick with this one or try to find a version that I would consider more stable.

Excalibur212 commented 3 years ago

@josesa This is awesome, thanks!! Not being a developer, though, this is mostly Greek to me.... Do you know how to fix and can you fork + post on a repo, since @yuliskov doesn't even seem interested in fixing misspellings on the 1st word of his website ("nova-days", LOL), much less his code??

sami155 commented 3 years ago

Hello? Still the same issue