search

yulqen / bcompiler-engine

MOVED: A Python library to alleviate the pain of using Excel spreadsheets to collect data from your stakeholders.
https://git.sr.ht/~yulqen/bcompiler-engine
MIT License
4 stars 1 forks source link

Is it correct that export should not proceed if keys in datamap that are not in the master? #21

Closed yulqen closed 4 years ago

yulqen commented 4 years ago

@banillie - is this expected/wanted functionality? What are the issues with this, if any? I presume we did this for a reason (the datamap is the "single version of the truth"/contact, etc), but I was wondering whether this needs to be considered. Not urgent but worth asking.

https://github.com/hammerheadlemon/bcompiler-engine/blob/c1eca5b2ceef617923d64337b831931b4a43c0ad/engine/use_cases/output.py#L73-L83

banillie commented 4 years ago

Hi @hammerheadlemon , yes I think we did this for a reason and it should stay that way. I guess the thinking was it's ok to have a key in the master but not the datamap as you might chose to filter out that key, but if you have a key in your datamap and not in master its a problem as your trying to actively work with a key and data that doesn't exist so the user needs a big warning - i.e. process stops - to handle as something has gone wrong.

But, yes I think it was designed in on purpose and is working well at the moment, so is not something we're having any problems with

yulqen commented 4 years ago

Excellent - thanks @banillie.