search

yulqen / bcompiler-engine

MOVED: A Python library to alleviate the pain of using Excel spreadsheets to collect data from your stakeholders.
https://git.sr.ht/~yulqen/bcompiler-engine
MIT License
4 stars 1 forks source link

TypeError if TEMPLATE_ROW_LIMIT not in config.ini #31

Closed yulqen closed 3 years ago

yulqen commented 3 years ago

When running datamaps import templates -m with no TEMPLATE_ROW_LIMIT in config.ini, TypeError is raised:

Traceback (most recent call last):
  File "/usr/lib/python3.9/concurrent/futures/process.py", line 243, in _process_worker
    r = call_item.fn(*call_item.args, **call_item.kwargs)
  File "/usr/lib/python3.9/concurrent/futures/process.py", line 202, in _process_chunk
    return [fn(*args) for args in chunk]
  File "/usr/lib/python3.9/concurrent/futures/process.py", line 202, in <listcomp>
    return [fn(*args) for args in chunk]
  File "/home/lemon/code/python/bcompiler-engine/engine/utils/extraction.py", line 473, in template_reader
    if rowcnt > int(Config.TEMPLATE_ROW_LIMIT): 
TypeError: int() argument must be a string, a bytes-like object or a number, not 'NoneType'
"""
yulqen commented 3 years ago

As of b43a545 TEMPLATE_ROW_LIMIT has been removed from config.ini. Need to implement CLI argument to implement the same.

yulqen commented 3 years ago

--rowlimit option has been added datamaps v1.1.0 which maps to adapter changes in bcompiler-engine.