search

yulqen / bcompiler-engine

MOVED: A Python library to alleviate the pain of using Excel spreadsheets to collect data from your stakeholders.
https://git.sr.ht/~yulqen/bcompiler-engine
MIT License
4 stars 1 forks source link

Ensure that validation report reports on empty cells #33

Closed yulqen closed 3 years ago

yulqen commented 3 years ago

Here is my TODO from engine.use_cases.parsing (circa line 90) before resetting:

 # TODO
    #
    # When importing from a template, if the cell is empty, it passes as an
    # empty value to the master. Fine.

    # Currently the validation report does not catch cells that are empty in
    # the populated template. An example is "Controls Project ID number"
    # from the datamap in dft_all_files_for_million_row_issue30.zip Q3 datamap.
    #
    # That is the result of only doing the vtype stuff below if c == cellref..
    # In other words, no empty cells from the populated template go into the
    # validation report. And we probably want that.
yulqen commented 3 years ago

Fixed with 69e38c4bab2d05020c44e45f8deacfaa010d5483.

yulqen commented 3 years ago

Currently, if a dml is not typed and the value is empty, validation reports it as a FAIL. It should be UNTYPED.