search

yumashino / Camera-Calibration-with-ChArUco-Board

Camera intrinsic parameters estimation using a ChArUco board
MIT License
0 stars 0 forks source link

nit: variance unit #1

Closed truher closed 8 months ago

truher commented 8 months ago

https://github.com/yumashino/Camera-Calibration-with-ChArUco-Board/blob/8d3320777bbe39141169de8cdb205525274eacf8/calibrate_camera_with_charuco.py#L71

hey, i love that you put this up, thank you! i did fine one tiny error that you might want to know about, the units of variance are squared so to convert to meters you have to divide by 1e6 not 1e3.

thanks again!

yumashino commented 8 months ago

That's exactly right! I have committed the revised version (https://github.com/yumashino/Camera-Calibration-with-ChArUco-Board/commit/1d05012b4d1d168c68b37944d8585d624760293f). Thank you!