search

yume-chan / ya-webadb

ADB in your browser
https://tangoapp.dev/
MIT License
2.24k stars 298 forks source link

[Feature request] Support of [adb root] and [adb kill-server] #627

Closed StephenHoo closed 6 months ago

StephenHoo commented 6 months ago

Pre-issue checklist

How can Tango be improved?

  1. Sometime the connection returns fail and I should run [adb kill-server] in terminal, can this command be suppoted?
  2. Meanwhile, [adb root] is also an important adb command for me and I found there is no implement in webadb, Is there any solution for this command?

How should the API change?

Just give an API like adb.power.powerOff()

(Optional) Other information

No response

glitch128 commented 6 months ago

Adb kill-server can't be used without connection to the device, which is blocked

yume-chan commented 6 months ago

Sometime the connection returns fail and I should run [adb kill-server] in terminal, can this command be suppoted?

In ADB client mode it's already supported: https://docs.tangoapp.dev/tango/server/commands/#kill-server

In direct connection mode it's not possible to connect to ADB server and issue kill-server command.

Meanwhile, [adb root] is also an important adb command for me and I found there is no implement in webadb, Is there any solution for this command?

adb.createSocket("root:")

StephenHoo commented 6 months ago

Thanks for reply, it helps me a lot! I will try server connection instead.