search

yumorishita / LiCSBAS

LiCSBAS: InSAR time series analysis package using LiCSAR products
https://doi.org/10.3390/RS12030424
GNU General Public License v3.0
224 stars 109 forks source link

python package ? #10

Closed sahitono closed 4 years ago

sahitono commented 4 years ago

Hi, why not create python wheel and conda package ? I think it will be easier to use, install and manage. People who use it won't need to bother about installing dependencies and setting up environment variable.

yumorishita commented 4 years ago

Thank you for your suggestion. I am sorry for bothering every user to prepare the python environment, but indeed I am not very familiar with python environment. I would like to focus on developing technical things about InSAR at the moment. I would appreciate if someone could share the easy way to create the environment.

sahitono commented 4 years ago

It can be done with github action. I can help to set it up, but the project directory need to be restructured. This project is great, thank you for creating it.

yumorishita commented 4 years ago

I have uploaded LiCSBAS.yml to create an "licsbas" environment by conda, and also updated the wiki page. Do you think it is useful? @sahitono

sahitono commented 4 years ago

@yumorishita that's useful for creating anaconda environment. I think it will be better to include the package version too, so there wont be a problem when installs different major version. Because conda sometimes install gdal version 2 not gdal 3.

Btw I have ported the bash script into powershell script so it can be used by windows user too. i can give it to you, if you are interested with it.

yumorishita commented 4 years ago

Thank you for your comments. I agree that the package version should be included, but I don't know what version can work or not for each package. I thought the latest version is installed without the explicit version and it would make no problem.

I have never used powershell. I would appreciate if you could upload the script on your repository or somewhere. I will link to it.

sahitono commented 4 years ago

What if the package version is the major version of what you currently uses ?

I'll create a fork of it asap, because i made some changes in the joining of url path. Because os.path in windows is backslash which is not a valid url path, so i use posix.path instead os.path.

yumorishita commented 4 years ago

I basically use the latest version, but it is not always required. I wonder if the unnecessary version specification increases conflict of multiple packages. LiCSBAS should not require the latest version for a certain package. If no specification of the package version does not cause a significant problem, I would like to keep the current yml file.

sahitono commented 4 years ago

I think there won't be significant problem

Zeeshan-Ali1992 commented 3 years ago

@yumorishita that's useful for creating anaconda environment. I think it will be better to include the package version too, so there wont be a problem when installs different major version. Because conda sometimes install gdal version 2 not gdal 3.

Btw I have ported the bash script into powershell script so it can be used by windows user too. i can give it to you, if you are interested with it.

Hello sahitono. Kindly share the "bash script" which you added to Powershell script to run it using Windows OS also.

sahitono commented 3 years ago

@Zeeshan-Ali1992 Hi, sadly I don't recommend it to you because I modified the old version of LiCSBAS to be compatible with windows. I recommend you to use WSL to run Linux on windows simultaneously without VM.