yumyv / epam_fe_2019_myronets

Epam study project on native js
Apache License 2.0
0 stars 0 forks source link

HW10-JS-intro #10

Open Tttaras1 opened 4 years ago

Tttaras1 commented 4 years ago

Hello! • Please check your code at w3c validation before finish your work. You have some errors. • Your links in header don't work.( • Also, please avoid to use elements without blocks. Element cant exist without block. image • Why are you using this class here? We easily can replace it with<b></b>. Also do not use same element inside each other. image In this case (for ex. if we need to add some additional styles) your probably could do something like that:

<p class="post__text">
          text
    <span class="post__additional-styled-text">
          additional styled text
    </span>
</p>

• Please, do not use empty elements for render dot. Use pseudo elements instead. image

• From js part everything is fine.

At all I like your work. Good BEM and SCSS usage and good class naming. Good job! If you have any questions, feel free to contact me by email or under this comment. Good luck!

yumyv commented 4 years ago

Okay, I'll know. Thank you for the feedback.

Tttaras1 commented 4 years ago

• And also, please follow the according design, you have good pixelperfect layout, but you forgot to add search icon in input. image • Also, there should be hover effect. image • Incorrect indents here: image and here: image