search

yumyv / epam_fe_2019_myronets

Epam study project on native js
Apache License 2.0
0 stars 0 forks source link

HW14-DOM: Overview + Date #14

Open Tttaras1 opened 4 years ago

Tttaras1 commented 4 years ago

Hi!

• for what reasoun do you using 3 varriables of your post rating? It's not a major thing, but i think you should define 1 property with your post rating. image

• Dont store your tags in JSON. It's just recomendation. helpful link: https://www.freeformatter.com/json-escape.html image

• It's not good that you load your main js on each page. You load data which your will not use on the page. You could create seperate files for each page and probably you could create utils.js file with all you data logic functions.

• I like your implementation with es6 classes. Good job!

yumyv commented 4 years ago

Okay, I must create two variables: countOfStars and CountOfFullStars? Thanks for the link and feedback.