Open SynytsinArtem opened 4 years ago
Hi! Sorry for the delay, not enough hours in a day) The page looks nice, and you used a lot of sass features, well done.
Task 1:
In "_vars.scss" should be color variables definitions: $black: #000; $white: #fff;
$black: #000;
$white: #fff;
And in "_color-matrix.scss" should be variables that you will use for your styles: $primaryColor: $black; $secondaryColor: $white;
$primaryColor: $black;
$secondaryColor: $white;
Task 2:
This should be <button> element, <input type="submit"> uses in form:
<button>
<input type="submit">
You don't need a <form> element here, checkboxes can be used without form:
<form>
It's better to use <a> as pagination elements:
<a>
It's okay I understand) Thanks for the feedback.
Hi! Sorry for the delay, not enough hours in a day) The page looks nice, and you used a lot of sass features, well done.
Task 1:
In "_vars.scss" should be color variables definitions:
$black: #000;
$white: #fff;
And in "_color-matrix.scss" should be variables that you will use for your styles:
$primaryColor: $black;
$secondaryColor: $white;
Task 2:
This should be
<button>
element,<input type="submit">
uses in form:You don't need a
<form>
element here, checkboxes can be used without form:It's better to use
<a>
as pagination elements: