search

yungtry / CatalinaScrobbler

🎵 The one and only working Last.fm scrobbler for macOS Catalina / Apple Music 🎵
GNU Affero General Public License v3.0
46 stars 3 forks source link

Memory Leak? #3

Closed Tom34772 closed 5 years ago

Tom34772 commented 5 years ago

That’s way too much memory for it to be using, correct?

Screen Shot 2019-07-12 at 10 22 42 AM

Thank you for your work! Tom

yungtry commented 5 years ago

Thank you for reporting the issue. The memory leak is probably caused by loop updating data in the menu bar as there is no native way of updating it in electron (https://github.com/electron/electron/issues/10951#issuecomment-452809202). I'm going to implement this in other way than a loop. Meanwhile when I work on it, you can use the older version of application (1.0.2) without "graphical interface", which as I suppose did not have this kind of issue.

yungtry commented 5 years ago

https://github.com/yungtry/CatalinaScrobbler/releases/tag/1.0.4 Let me know if it still occurs 😊.

Tom34772 commented 5 years ago

Both the 1.0.4 beta and 1.0.4 final version are still leaking memory. This morning, I watched CS go up probably a 3-4 MB every 5 seconds or so.

yungtry commented 5 years ago

Happened to me for the first time today. I'm currently trying to figure out how to reproduce this. If anyone has any clues then I would be more than grateful if you could share them. For now it seems like something bugs out after few hours of listening to music causing the app to call few instances at the same time.

yungtry commented 5 years ago

I'm going to close it for now since the app has been rewritten and the leak doesn't seem to be the case anymore. If anyone still encounters memory leaking, please mention me here I will reopen that issue.