yunhostnet / pywebsocket

Automatically exported from code.google.com/p/pywebsocket
0 stars 0 forks source link

pywebsocket should log a more friendly error #28

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Asked by ap on e-mail, and by bdash on #webkit.

https://bugs.webkit.org/show_bug.cgi?id=32058

pywebsocket shows following log now:
[2009-12-01 22:43:55,992] [WARNING] root: mod_pywebsocket:
web_socket_transfer_data raised exception: Traceback (most recent call 
last):
  File
"/Volumes/Big/WebKit-BuildSlave/leopard-intel-debug-
tests/build/WebKitTools/pywebsocket/mod_pywebsocket/dispatch.py",
line 179, in transfer_data
    transfer_data_(request)
  File "<string>", line 38, in web_socket_transfer_data
  File
"/Volumes/Big/WebKit-BuildSlave/leopard-intel-debug-
tests/build/WebKitTools/pywebsocket/mod_pywebsocket/msgutil.py",
line 52, in send_message
    request.connection.write('\x00' + message.encode('utf-8') + '\xff')
  File "WebKitTools/pywebsocket/mod_pywebsocket/standalone.py", line 
118, in
write
    return self._request_handler.wfile.write(data)
  File
"/System/Library/Frameworks/Python.framework/Versions/2.5/lib/python
2.5/socket.py",
line 262, in write
    self.flush()
  File
"/System/Library/Frameworks/Python.framework/Versions/2.5/lib/python
2.5/socket.py",
line 249, in flush
    self._sock.sendall(buffer)
  File "<string>", line 1, in sendall
error: (32, 'Broken pipe')

the server should log a more friendly error to indicate what happened 
rather than logging a backtrace.

Original issue reported on code.google.com by ukai@chromium.org on 2 Dec 2009 at 8:41

GoogleCodeExporter commented 9 years ago
I'll take care of this.

Original comment by yuzo@chromium.org on 3 Dec 2009 at 5:13

GoogleCodeExporter commented 9 years ago

Original comment by yuzo@chromium.org on 7 Dec 2009 at 2:21