search

yunhuizhu / memcached

Automatically exported from code.google.com/p/memcached
0 stars 0 forks source link

timedrun.c L103 #237

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 

return spawn_and_wait(argc+2, argv+2);
--> 
argc+2 or argc-2 ??

Original issue reported on code.google.com by MagicBoh...@gmail.com on 23 Nov 2011 at 9:36

GoogleCodeExporter commented 9 years ago 
what?

Original comment by dorma...@rydia.net on 7 Dec 2011 at 11:49

GoogleCodeExporter commented 9 years ago 
i think L103 should be  "return spawn_and_wait(argc-2, argv+2);".
the first param  is "argc - 2" not  "argc + 2".

Original comment by MagicBoh...@gmail.com on 8 Dec 2011 at 1:07

GoogleCodeExporter commented 9 years ago 
is there a bug or an issue or a failure or anything to go along with this? I 
don't really feel like changing code without knowing what the reporter expects 
to happen.

Original comment by dorma...@rydia.net on 12 Jan 2012 at 1:24

GoogleCodeExporter commented 9 years ago 
I think the reporter is correct.  It isn't breaking anything because argc is 
effectively unused.  I'll just take it out.

Original comment by dsalli...@gmail.com on 12 Jan 2012 at 3:29

GoogleCodeExporter commented 9 years ago 
dormando:  Please review the change in my master and grab it if you think it's 
reasonable.

Original comment by dsalli...@gmail.com on 12 Jan 2012 at 3:30