yunhuizhu / memcached

Automatically exported from code.google.com/p/memcached
0 stars 0 forks source link

USE_SYSTEM_MALLOC fails #277

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1.insert a "#define USE_SYSTEM_MALLOC" in slabs.c
2.make test
3.

What is the expected output? What do you see instead?
Expected: passing all tests.
Instead:
memcached-debug: items.c:178: do_item_alloc: Assertion `it->slabs_clsid == 0' 
failed.
testapp: testapp.c:697: safe_recv: Assertion `nr != 0' failed.

What version of the product are you using? On what operating system?
memcached 1.4.13 from github
uname -a
Linux alice 2.6.32-41-generic #89-Ubuntu SMP Fri Apr 27 22:18:56 UTC 2012 
x86_64 GNU/Linux

Please provide any additional information below.
Is the system malloc supposed to work? I am working on the automatic shrinkage 
of memory pages, and I need the use of system malloc to be able to free pages.

Original issue reported on code.google.com by ladyp...@gmail.com on 24 Jun 2012 at 1:23

GoogleCodeExporter commented 9 years ago
I implemented the dynamic memory use (dynamic changes of mem_limit according to 
a user command, and automatic selection of the slabclasses from which to take 
the memory) without defining USE_SYSTEM_MALLOC.
However, USE_SYSTEM_MALLOC is indeed faulty, and I suggest to remove these code 
snippets altogether, to clean the code.

Original comment by ladyp...@gmail.com on 27 Jun 2012 at 6:32

GoogleCodeExporter commented 9 years ago
Yeah that's bitrotted. we'll remove it.

Original comment by dorma...@rydia.net on 14 Jul 2012 at 11:26

GoogleCodeExporter commented 9 years ago
removed in my slab_boost branch. will be gone from 1.4.14

Original comment by dorma...@rydia.net on 27 Jul 2012 at 9:34