search

yunify / hostnic-cni

hostnic-cni is a Container Network Interface plugin.
Apache License 2.0
30 stars 12 forks source link

enhancements #65

Closed magicsong closed 4 years ago

magicsong commented 4 years ago

in this pr:

  1. the hostnic-daemon is now charging of write cni config file (like runtime generating)
  2. precheck device number of nic

/kind bug

ks-ci-bot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: magicsong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/yunify/hostnic-cni/blob/master/OWNERS)~~ [magicsong] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 4 years ago

Codecov Report

Merging #65 into master will decrease coverage by 1.67%. The diff coverage is 6.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
- Coverage   56.56%   54.88%   -1.68%     
==========================================
  Files          10       10              
  Lines        1227     1270      +43     
==========================================
+ Hits          694      697       +3     
- Misses        431      469      +38     
- Partials      102      104       +2
Impacted Files Coverage Δ
pkg/ipam/datastore/datastore.go 80.51% <0%> (-0.71%) :arrow_down:
pkg/ipam/grpc_handlers.go 0% <0%> (ø) :arrow_up:
pkg/ipam/ipam.go 38.34% <8.33%> (-6.89%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8dc14bf...55d1a94. Read the comment docs.