Closed magicsong closed 4 years ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: magicsong
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Merging #66 into master will decrease coverage by
1.36%
. The diff coverage is22.53%
.
@@ Coverage Diff @@
## master #66 +/- ##
==========================================
- Coverage 54.88% 53.51% -1.37%
==========================================
Files 10 10
Lines 1270 1323 +53
==========================================
+ Hits 697 708 +11
- Misses 469 509 +40
- Partials 104 106 +2
Impacted Files | Coverage Δ | |
---|---|---|
pkg/ipam/ipam.go | 34.41% <0%> (-3.93%) |
:arrow_down: |
pkg/retry/retry.go | 100% <100%> (ø) |
:arrow_up: |
pkg/networkutils/networkutil.go | 46.55% <16.66%> (-0.6%) |
:arrow_down: |
pkg/ipam/vxnet.go | 52.56% <40.62%> (-4.58%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a4e6ec0...c1db287. Read the comment docs.
add lots of retry to avoid inconsistency with iaas
/kind bug