search

yunify / qingcloud-csi

Kubernetes volume plugin based on CSI specification which support block storage of qingcloud
Apache License 2.0
36 stars 22 forks source link

Fixed target path check error when node published volume. #181

Closed yunkunrao closed 3 years ago

yunkunrao commented 3 years ago

When node pushed volume, target path should be checked by GetTargetPath() other than GetStagingTargetPath().

min-zh commented 3 years ago

/lgtm

min-zh commented 3 years ago

/approve

shaowenchen commented 3 years ago

/assign @min-zh

shaowenchen commented 3 years ago

please try again to merge this pr @min-zh

zheng1 commented 3 years ago

/kind bug

ks-ci-bot commented 3 years ago

@shaowenchen: GitHub didn't allow me to request PR reviews from the following users: yunkunrao.

Note that only yunify members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/yunify/qingcloud-csi/pull/181#issuecomment-697179380): >/cc @yunkunrao Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ks-ci-bot commented 3 years ago

@shaowenchen: GitHub didn't allow me to request PR reviews from the following users: yunkunrao.

Note that only yunify members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/yunify/qingcloud-csi/pull/181#issuecomment-697177604): >/cc @yunkunrao Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
min-zh commented 3 years ago

/approve

ks-ci-bot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: min-zh, yunkunrao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/yunify/qingcloud-csi/blob/master/OWNERS)~~ [min-zh] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment