yunify / qingcloud-csi

Kubernetes volume plugin based on CSI specification which support block storage of qingcloud
Apache License 2.0
36 stars 22 forks source link

about retryIntervalMax and retryTimesMax #184

Closed stoneshi-yunify closed 2 years ago

stoneshi-yunify commented 2 years ago

What would you like to be added: the arguments:

    retryIntervalMax = flag.Duration("retry-interval-max", 2*time.Minute, "Maximum retry interval of failed deletion.")
    retryTimesMax    = flag.Int("retry-times-max", 10, "Maximum retry times of failed detach volume.")

retryIntervalMax: is this still needed? as the sidecar already have exponential backoff.

retryTimesMax: 10 is too small as default. 100 may be better. And it should allow to completely disable this limits. such as a value of 0 or -1.