search

yunity-archive / ARCHIVED-yunity-webapp-mobile

Mobile webapp
GNU Affero General Public License v3.0
6 stars 1 forks source link

Look into improving / restructuring routes setup #34

Open nicksellen opened 8 years ago

nicksellen commented 8 years ago

At the moment any nested pages are not visible as me and @copygirl rejigged some things around to improve the layout stuff for angular-material.

Maybe change routes to just have template and controller (instead of directive-per-page).

Maybe move route definitions into the modules they belong it.

Maybe remove nested route configs and just use ng-include, and/or directives to handle reusable layout concepts.

Not sure.

copygirl commented 8 years ago

For now I've applied a temporary fix (?) that can be seen in 1fe1e78.

copygirl commented 8 years ago

I've decided to un-nest routes that don't make sense to be nested (see a0a118e), as that would otherwise cause the parent controller being used, which is not what we want most of the time.

Leaving the issue up since there are still some unanswered questions.