search

yunjianwu / achartengine

Automatically exported from code.google.com/p/achartengine
0 stars 0 forks source link

zoomOut not working after updating r362 #172

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
I'm creating view:

mChartView = ChartFactory.getTimeChartView(this, mDataset,mRenderer, "H:mm:ss");

Trigering zoomout:

mChartView.zoomOut();

Before I used older revision and it worked, now it fails.

Anybody have the same problem?

Regards,
Toni

Original issue reported on code.google.com by toniabc@gmail.com on 27 Jan 2012 at 6:17

GoogleCodeExporter commented 9 years ago 
actually I tested revisions one by one and it stops working at revision 320.

Toni

Original comment by toniabc@gmail.com on 28 Jan 2012 at 12:56

GoogleCodeExporter commented 9 years ago 
I think i found the problem in util/Zoom.java:

if (limitsReachedX) {
  newWidth *= mZoomRate;
}

and 

if (limitsReachedY) {
   newHeight *= mZoomRate;
}

when I commented if statements it works... I couldn't found for what 
limitsReachedX nad limitsReachedY serve for.

Toni

Original comment by toniabc@gmail.com on 28 Jan 2012 at 3:25

GoogleCodeExporter commented 9 years ago 
Same problem, revision 362.

I've commented the if statements and it works fine now.

Original comment by renws1990@gmail.com on 2 Feb 2012 at 12:34

GoogleCodeExporter commented 9 years ago 
How do i fix this? I downloaded the newest revision today and I am having the 
same problem

Original comment by subayya...@gmail.com on 9 Mar 2012 at 7:59

GoogleCodeExporter commented 9 years ago 
just follow the comment no. 2.

Original comment by toniabc@gmail.com on 9 Mar 2012 at 9:05

GoogleCodeExporter commented 9 years ago 
Sorry, I dont have the source code. Is there anyway I can have the updated jar 
file?

Original comment by subayya...@gmail.com on 9 Mar 2012 at 1:06

GoogleCodeExporter commented 9 years ago 
The owner of this project seems quite busy and has no time on AChartEngine, you 
can send me an email and I will send your a working jar file.  
renws1990@gmail.com

Original comment by renws1990@gmail.com on 9 Mar 2012 at 1:12

GoogleCodeExporter commented 9 years ago 
Sent you an email.

Original comment by subayya...@gmail.com on 9 Mar 2012 at 1:48

GoogleCodeExporter commented 9 years ago 
limitsReachedX and limitsReachedY were intended for the multiple Y axis charts 
not allowing pan or zoom if one of the charts of the multiple ones has reached 
its pan or zoom limits.
So, the solution is not commenting out that code but rather find the real issue.

I am currently very busy, indeed, but I will hopefully have time to work on ACE 
again.

Original comment by dandrome...@gmail.com on 9 Mar 2012 at 7:39

GoogleCodeExporter commented 9 years ago 
Hi Dan, glad you are back.

Commenting out the code is just a dirty solution to make basic zooming 
functions work.
Now I know the intention of introducing limitsReachedX and limitsReachedY. I'll 
try to try to write a patch for that, could you have a check once I've done?

Original comment by renws1990@gmail.com on 9 Mar 2012 at 11:08

GoogleCodeExporter commented 9 years ago 
Fixed in SVN rev. r363.
Thanks for your help on this issue.

Original comment by dandrome...@gmail.com on 10 Mar 2012 at 4:58