yunjianwu / achartengine

Automatically exported from code.google.com/p/achartengine
0 stars 0 forks source link

setPanEnabled(boolean enabled) is not correctly overridden in XYMultipleSeriesRenderer #246

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Call setPanEnabled(false) on an XYMultipleSeriesRenderer object
2. The graph is still pan-able.

What is the expected output? What do you see instead?
setPanEnabled(false) should lock the graph for panning.

Please provide a source code snippet that we can use to replicate the issue.
mRenderer.setPanEnabled(false); //Does not work
mRenderer.setPanEnabled(false, false); //Works

What version of the product binary library are you using?
1.0.0

Please provide any additional information below.

Add following to XYMultipleSeriesRenderer

  /**
   * Sets the enabled state of the pan.
   * 
   * @param enabled pan enabled
   */
  @Override
  public void setPanEnabled(boolean enabled) {
    mPanXEnabled = enabled;
    mPanYEnabled = enabled;
  }

Original issue reported on code.google.com by jonas.es...@gmail.com on 29 Aug 2012 at 12:20

GoogleCodeExporter commented 9 years ago
I had this issue to. Is there a way to become committer on this project so that 
we can fix small issues like this as a community?

Original comment by jethroborsje on 4 Sep 2012 at 9:33

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
You might try sending a patch to Dan. contact [at] achartengine.org

Original comment by jonas.es...@gmail.com on 5 Sep 2012 at 6:22

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
Based on the proposed fix of the bug reporter I've created a patch and attached 
it to this comment.

Original comment by jethroborsje on 10 Sep 2012 at 5:50

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks for the patch.

Original comment by dandrome...@gmail.com on 10 Sep 2012 at 6:07