search

yunjianwu / achartengine

Automatically exported from code.google.com/p/achartengine
0 stars 0 forks source link

FillOutsideLine Gradient #276

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
In this patch I implemented the gradients for the FillOutsideLine.

There are some limitations implementing FillOutsideLine like a enum. It is not 
posible to have two lines with FillOutsideLine.BELOW but with differents 
colors. If you want I can fix this problem in future patches.

Original issue reported on code.google.com by braisga...@gmail.com on 12 Feb 2013 at 6:20

Attachments:

GoogleCodeExporter commented 9 years ago 
One question: I have a demo chart where I test all the features that I am 
releasing. Do you want me to include this class?

Original comment by braisga...@gmail.com on 12 Feb 2013 at 6:27

GoogleCodeExporter commented 9 years ago 
Don't set the project target to android-17.

Please use the Android suggested naming for variables: gradient should be 
mGradient.

I am not sure I understand the gradient you have added. Please take a look at 
the Sales comparison chart. If I drag it up, it becomes green, otherwise it is 
blue. Gradient charts are usually based on values, like in the Temperature 
range chart example, not on the position of the chart relative to the screen. I 
find it useless the way it is now.

The Range bar chart was broken. Please make sure you test that all the demo 
charts are still working when modifying something that critical as the 
drawSeries method is. Let's struggle not to modify these signatures too much.

Don't add your demo chart, just make sure the existing ones still work.

I'll let this issue opened, as the current gradient implementation is not 
valid. Please let me know if you want to change it to reflect chart values or I 
will remove the code.

Original comment by dandrome...@gmail.com on 16 Feb 2013 at 1:59

GoogleCodeExporter commented 9 years ago

Original comment by dandrome...@gmail.com on 20 Feb 2013 at 8:27

GoogleCodeExporter commented 9 years ago 
I'm sorry for late response. This implementation was thought only for 
decorative purposes. But I like the idea of chart gradient based on values. I 
will change my code to use values. Then it can be used for decorative purposes 
or for not useless purposes ;).

Original comment by braisga...@gmail.com on 21 Feb 2013 at 8:26

GoogleCodeExporter commented 9 years ago 
Try not to alter the drawSeries signature.

Original comment by dandrome...@gmail.com on 21 Feb 2013 at 8:33