search

yunojuno / django-juno-testrunner

A more useful (and slightly more glamorous) test runner for Django 1.6+ from the folks at YunoJuno
MIT License
7 stars 9 forks source link

Fix for JUnit XML generator #19

Closed gergelypolonkai closed 8 years ago

gergelypolonkai commented 8 years ago

After adding some coverage tests (which in itself is really educating) I found two things:

  1. my JUnit XML generator will NEVER run
  2. almost 40% of the code is not tested

This PR addresses the bug that derives from item 1.

Signed-off-by: Gergely Polonkai gergely@polonkai.eu

Geekfish commented 8 years ago

Hey @gergelypolonkai, Many thanks for the fix, and sorry it took a long time to look into this!

I gave this a try too and it looks fine, but I noticed that even though we now have TEST_RUNNER_JUNIT_XML in the settings, it isn't documented in the README, which would be good to have so that people are made aware of the feature. Could you use this as an opportunity to update the docs too?

gergelypolonkai commented 8 years ago

There you go, I also did a rebase. I put a new subsection under Usage, but maybe that’s an overkill. Let me know if it should go somewhere else.

hugorodgerbrown commented 8 years ago

Thanks @gergelypolonkai

gergelypolonkai commented 8 years ago

You’re welcome. Is there a plan when this will be released?