search

yunruse / Noether

Just another units package
MIT License
9 stars 0 forks source link

Catalogue has duplicate entries #11

Closed yunruse closed 1 year ago

yunruse commented 1 year ago

General info

The catalogue item should, if a new unit is registered, merge names. This will avoid complication in catalogue.json.

Steps

>>> catalogue.register("feet", foot)
>>> catalogue.units['foot'].names
('foot',)
>>> catalogue.units['feet'].names
('foot',)

Expected behaviour

Both units should be the same, and said unit should have "feet" as a name too.

Actual behaviour

No name assigning is done.

yunruse commented 1 year ago

Well, 15.0 d # time, 0.51× lunation later, and I have no idea what this was supposed to be fixing, so I suppose it will be closed unless I somehow figure out what this was for.

I was about to fix it, but the fix feels like it would add an annoying extra tiny bit of slowdown to stuff.