search

yuntaozhu / closure-library

Automatically exported from code.google.com/p/closure-library
0 stars 0 forks source link

No good way to remove a goog.graphics.Element from a goog.graphics.CanvasGraphics #110

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. Make a script that uses an instance of goog.graphics.CanvasGraphics.
(I'm trying to make a level designer for a platform game, which needs a
delete option for unwanted blocks)
2. Include a dynamic way to add elements to the graphics instance. (eg. a
button with a click event)
3. Create a delete button - there's no way to make it work.

What is the expected output? What do you see instead?
goog.graphics.Element.disposeInternal doesn't remove the element (or even
make it invisible)
goog.graphics.CanvasGraphics.removeElement doesn't work on CanvasGraphics
(this is the one I suggest the fix for)

What version of the product are you using? On what operating system?
r26 compiled with Closure Compiler on Windows XP
Browsers: Firefox 3.7a1pre and Google Chrome 4.0.295.0 beta

Please provide any additional information below.
I'm using CanvasGraphics directly because it can receive events in Firefox
(SVG can't) and it renders faster than any DOM implementation of a graphics
library could.

Original issue reported on code.google.com by Nightgunner5 on 30 Jan 2010 at 8:20

GoogleCodeExporter commented 8 years ago 
Confirmed that this bug is still in the Library. We have patched it, which you 
can find attached.

As for my CLA, I pass the ownership of the patch file to user price.c, who has 
a valid CLA.

Original comment by stvhl00 on 28 Jun 2011 at 8:04

Attachments:

GoogleCodeExporter commented 8 years ago 
I'm Steven's colleague, find the patch attached. The CLA is for Scott Logic 
Limited, and I'm the single named contributor Chris Price.

Original comment by pric...@gmail.com on 28 Jun 2011 at 8:14

Attachments:

GoogleCodeExporter commented 8 years ago 
Confirming above comment from Chris.

Original comment by stvhl00 on 28 Jun 2011 at 8:17

GoogleCodeExporter commented 8 years ago

Original comment by chrishe...@google.com on 23 Apr 2012 at 9:17