search

yuphin / Lumen

A Vulkan Raytracing framework for various bidirectional path tracing techniques
MIT License
449 stars 29 forks source link

different SPPM, BDPT, Restir GI, Restir PT vs VCM/Path #30

Closed tigrazone closed 8 months ago

tigrazone commented 8 months ago

Hello. In new bsdf branch I have different result when I change integrator. VCM image

Path image

VCM and Path is almost same.

SPPM, darker image

BDPT is broken image

My camera settings for this view is

    "camera": {
        "fov": 45,
        "position": [
            -4.404,
            -0.887,
            10.913
        ],
        "dir" : [
            0,0.09, 2
        ]
    },
tigrazone commented 8 months ago

Restir GI image

Restir PT image

yuphin commented 8 months ago

BDPT part is fixed. SPPM also supports env. lighting but it's supposed to be biased in the first place. ReSTIR GI is not meant to be used with specular reflections. ReSTIR PT should be identical but I've yet to add support and validate for complex BSDFs ( + env. lighting).

tigrazone commented 8 months ago

SPPM goes to black on classroom, torus and bedroom scenes. I understand, you not finish implement principal, but maybe there is negative values for color or NaNs

tigrazone commented 8 months ago

"goes to black" maybe is nans. I fixed it in one of my last commits