convert caustics, cornell_box_disney scenes to new bsdf

yuphin / Lumen

A Vulkan Raytracing framework for various bidirectional path tracing techniques

MIT License

449 stars 29 forks source link

convert caustics, cornell_box_disney scenes to new bsdf #31

Closed tigrazone closed 8 months ago

tigrazone commented 8 months ago

yuphin commented 8 months ago

Thanks for adapting the old code. The branch (including the BSDF code) is still WIP so I'll have a look once everything else is sorted out.

tigrazone commented 8 months ago

still WIP

But your renderer is impressive. I'm waiting for your new commits. Looks good. Disney/principal bsdf well implemented here https://github.com/knightcrawler25/GLSL-PathTracer

yuphin commented 8 months ago

Thanks for the PR, I've adapted most of your changes with some modifications. There were a couple of flags missing while parsing Mitsuba materials so I've also adjusted them and I couldn't observe any ringing so far (Although things are still WIP). I'll close the PR for now and will address the remaining stuff pointed out in the issues.