search

yuphin / Lumen

A Vulkan Raytracing framework for various bidirectional path tracing techniques
MIT License
449 stars 29 forks source link

[Question] about restirgi #4

Closed trsh closed 1 year ago

trsh commented 1 year ago

I am lookin at src\shaders\integrators\restir\gi\temporal_reuse.rgen and buffer old_samples, and I can not understand where its being written. Only accessed at line 97.

yuphin commented 1 year ago

Thanks for pointing that out. In the release build it's copied via vkCmdCopyBuffer, see this line. It appears I've forgotten to copy it in the new render graph implementation.

PS: The current render graph doesn't support buffer-to-buffer copies as I'm adding features whenever I need them. I'll add it when I have time.

yuphin commented 1 year ago

Addressed in ea63f7380fa1d6b75f1792d9802157ad0cbe508c