search

yuphin / Lumen

A Vulkan Raytracing framework for various bidirectional path tracing techniques
MIT License
449 stars 29 forks source link

Disney material shader divergence #5

Closed yuphin closed 1 year ago

yuphin commented 1 year ago

Currently enabling Disney materials (ENABLE_DISNEY macro in src/shaders/commons.h) results in significant performance loss compared to the non-Disney counterpart. This issue needs to be investigated.

yuphin commented 1 year ago

In recent tests, I haven't observed any meaningful performance differences either on mobile or on desktop. (At least on scenes where either Disney or glossy BSDFs are present) Might be a driver related issue, albeit I've only tested it on Nvidia GPUs. Therefore closing this until further notice and leaving ENABLE_DISNEY flag by default.