Open mcruzdev opened 1 month ago
Seems it is right for asciidoctor (https://github.com/asciidoctor/asciidoctor/blob/main/lib/asciidoctor/converter/html5.rb#L193) but we also consider noheader there (https://github.com/yupiik/tools-maven-plugin/blob/master/asciidoc-java/src/main/java/io/yupiik/asciidoc/renderer/html/AsciidoctorLikeHtmlRenderer.java#L299).
We should probably add to the configuration a backward compatible toggle to keep current behavior since the reasoning was that when embed the title (=
) was managed by the embedder and not the renderer.
One way is to consider the notitle value instead of just testing the presence maybe? if false we use it whatever noheader is?
I have a test here:
The result is "" but the expected is to have
<h1>...
, It happens when I addnoheader
attribute, is it the expected behavior?I think it should be
<h1>...
no?Originally posted by @mcruzdev in https://github.com/yupiik/tools-maven-plugin/issues/18#issuecomment-2289398129