yura505 / robinbot

Robinhood API based swing trading bot
134 stars 35 forks source link

fast premature exit #19

Closed klepsydra closed 6 years ago

klepsydra commented 6 years ago

Hello, great work!

However, after I configured my own credentials and list of stocks in conf.js, it exits in about 2 seconds. No errors printed.

How do I troubleshoot?

I've dropped in "console.log('here!');" lines to infer it gets as far as ticker_instrument[ticker] = t.url; in instruments.js only once, but am really out of my league with nodejs.


./robinbot.js -s macd
*** ROBINBOT (paper mode) today: 2018-09-14 22:46:16
Downloading instruments: URA   

 node -v
v9.5.0

 lsb_release -a; uname -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 16.04.5 LTS
Release:        16.04
Codename:       xenial
Linux strategio 4.4.0-130-generic #156-Ubuntu SMP Thu Jun 14 08:53:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

npm install
npm WARN read-shrinkwrap This version of npm is compatible with lockfileVersion@1, but npm-shrinkwrap.json was generated for lockfileVersion@0. I'll try to do my best with it!
npm WARN robinbot@0.0.1 No repository field.

audited 490 packages in 4.545s
found 19 vulnerabilities (3 low, 11 moderate, 4 high, 1 critical)
  run `npm audit fix` to fix them, or `npm audit` for details

   ╭───────────────────────────────────────────────────────────────╮
   │                                                               │
   │       New minor version of npm available! 6.1.0 → 6.4.1       │
   │   Changelog: https://github.com/npm/npm/releases/tag/v6.4.1   │
   │               Run npm install -g npm to update!               │
   │                                                               │
   ╰───────────────────────────────────────────────────────────────╯

 npm update
npm WARN robinbot@0.0.1 No repository field.

+ robinhood@1.1.2
updated 1 package and audited 490 packages in 12.938s
found 19 vulnerabilities (3 low, 11 moderate, 4 high, 1 critical)
  run `npm audit fix` to fix them, or `npm audit` for details

npm audit
yura505 commented 6 years ago

Marcos, try to remove URA from the list, I think that not enough information from data source regarding this symbol. But I can investigate it later.

On Fri, Sep 14, 2018 at 3:56 PM Marcos Koby notifications@github.com wrote:

Hello, great work!

However, after I configured my own credentials and list of stocks in conf.js, it exits in about 2 seconds. No errors printed.

How do I troubleshoot?

I've dropped in "console.log('here!');" lines to infer it gets as far as ticker_instrument[ticker] = t.url; in instruments.js only once, but am really out of my league with nodejs.

./robinbot.js -s macd *** ROBINBOT (paper mode) today: 2018-09-14 22:46:16 Downloading instruments: URA

node -v v9.5.0

lsb_release -a; uname -a No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 16.04.5 LTS Release: 16.04 Codename: xenial Linux strategio 4.4.0-130-generic #156-Ubuntu SMP Thu Jun 14 08:53:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

npm install npm WARN read-shrinkwrap This version of npm is compatible with lockfileVersion@1, but npm-shrinkwrap.json was generated for lockfileVersion@0. I'll try to do my best with it! npm WARN robinbot@0.0.1 No repository field.

audited 490 packages in 4.545s found 19 vulnerabilities (3 low, 11 moderate, 4 high, 1 critical) run npm audit fix to fix them, or npm audit for details

╭───────────────────────────────────────────────────────────────╮ │ │ │ New minor version of npm available! 6.1.0 → 6.4.1 │ │ Changelog: https://github.com/npm/npm/releases/tag/v6.4.1 │ │ Run npm install -g npm to update! │ │ │ ╰───────────────────────────────────────────────────────────────╯

npm update npm WARN robinbot@0.0.1 No repository field.

  • robinhood@1.1.2 updated 1 package and audited 490 packages in 12.938s found 19 vulnerabilities (3 low, 11 moderate, 4 high, 1 critical) run npm audit fix to fix them, or npm audit for details

npm audit

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/yura505/robinbot/issues/19, or mute the thread https://github.com/notifications/unsubscribe-auth/AF3kc1wQWlKG40jXVqauuwfMPnsJQUvbks5ubBgYgaJpZM4Wp8GU .

klepsydra commented 6 years ago

Thanks for the tip!

For now, any idea where in the code I can make it skip over tickers it doesn't handle, rather than exiting the program entirely? Or enable some verbose error reporting, to help me at least generate a blacklist every time one fails?

I provide dynamic lists of stock to c.list in conf.js and don't really have control which get included at runtime.

klepsydra commented 6 years ago

The issue was with my data (fed from a text file). I wasn't aware of trailing whitespace in symbol names.

trim() took care if it in instruments.js:

tickers.push(symbol.trim() );