optimized some code in .bat files

[Migilint]

I optimized some code in .bat files. We don't need to lead to url files for use some commands, because we can use a PATH environment

[yuri-panchul]

I modified the solution in the following way. Can you check it on your side?

@echo off

echo ALL PROBLEMS > log.txt

where iverilog > nul 2>&1

if errorlevel 1 ( if exist C:\iverilog\bin\iverilog.exe ( for %%f in (.sv) do ( C:\iverilog\bin\iverilog -g2005-sv %%f >> log.txt 2>&1 C:\iverilog\bin\vvp a.out >> log.txt 2>&1 rem C:\iverilog\gtkwave\bin\gtkwave dump.vcd ) ) else ( echo ERROR: iverilog.exe is not in the path, is not in the default location C:\iverilog\bin or cannot be run. echo See README.md file in the package directory for the instructions on how to install Icarus Verilog. pause exit /b 1 ) ) else ( for %%f in (.sv) do ( iverilog -g2005-sv %%f >> log.txt 2>&1 vvp a.out >> log.txt 2>&1 rem gtkwave dump.vcd ) )

del /q a.out

findstr PASS log.txt findstr FAIL log.txt findstr error log.txt

On 2023-10-15 15:27, Vladimir Kalinovskiy wrote:

I optimized some code in .bat files. We don't need to lead to url files for use some commands, because we can use a PATH environment

YOU CAN VIEW, COMMENT ON, OR MERGE THIS PULL REQUEST ONLINE AT:

https://github.com/yuri-panchul/systemverilog-homework/pull/7

COMMIT SUMMARY

• 1fb466b [1] optimized some code in .bat files

FILE CHANGES

(2 files [2])

• M 01_combinational_logic/run_all_using_iverilog_under_windows.bat [3] (6)
• M 02_sequential_basics/run_all_using_iverilog_under_windows.bat [4] (6)

PATCH LINKS:

• https://github.com/yuri-panchul/systemverilog-homework/pull/7.patch
• https://github.com/yuri-panchul/systemverilog-homework/pull/7.diff

-- Reply to this email directly, view it on GitHub [5], or unsubscribe [6]. You are receiving this because you are subscribed to this thread.Message ID: @.***>

Links:

[1] https://github.com/yuri-panchul/systemverilog-homework/pull/7/commits/1fb466beb17feddcf3a8e5af6b489323643886b7 [2] https://github.com/yuri-panchul/systemverilog-homework/pull/7/files [3] https://github.com/yuri-panchul/systemverilog-homework/pull/7/files#diff-9480b6621ddb70657510679c9ae80f67e694ece68b7f6a16d7ef528997fef6f3 [4] https://github.com/yuri-panchul/systemverilog-homework/pull/7/files#diff-86a97311b1943ba6336f9dcedaca5ace4c54c0bdc959306dba64285d9caf0267 [5] https://github.com/yuri-panchul/systemverilog-homework/pull/7 [6] https://github.com/notifications/unsubscribe-auth/AC6OFWSPHM23UJMYFS6Q3R3X7RINXAVCNFSM6AAAAAA6BIWS7KVHI2DSMVQWIX3LMV43ASLTON2WKOZRHE2DIMBWGM4DKNQ

[Migilint]

I checked your modified solution and it works. In the future we can release some automatic solution (. sh or .bat file with uses git, how is released from others [pip, npm, and etc..] package managers) for installation all the packages/software for education.

Thanks for the message!)