HAL-impl layer between device crate and board support crate

jlecoeur commented 7 years ago

Hi,

Do you still work on this crate?

I think it would be cool to have another layer between this crate and the device crate:

stm32f40x: auto generated low level access to register
stm32f40x-hal: implementation of hal-embedded traits, provide configuration structs for each peripheral <- TODO
f4: pre-configured peripherals for the discovery board

The advantage would be less code duplication when implementing a board support crate (like f4) for other boards that use an f40x mcu.

What do you think?

yuri91 commented 7 years ago

I am totally for something like this.

I was waiting for embedded-hal to be more or less complete, but the basic stuff is there.

A reference implementation of those traits can be found on blue-pill.

jlecoeur commented 7 years ago

Ok! I also found this one https://github.com/nikhilkalige/stm32f411-bsp. I wonder how much of it can be reused for stm32f40x...

yuri91 commented 7 years ago

looking at the commit history, it seems that that is just a fork of the blue-pill crate with some modifications on top.

I think we can take a lot of inspiration from those for implementing the embedded-hal traits

yuri91 / f4