search

yuri91 / ili9341-rs

A WIP, no_std, generic driver for the ILI9341 (and ILI9340C) TFT LCD display
Apache License 2.0
57 stars 50 forks source link

Update embedded graphics to version 0.4.4 #1

Closed jamwaffles closed 5 years ago

jamwaffles commented 5 years ago

A lot has changed since 0.1.1 🙂 this PR just bumps the dependency and fixes the library integration to make it work/compile again. Tested on an actual display controlled by an STM32F103 "Blue Pill".

therealprof commented 5 years ago

@yuri91 Is there anything holding this up?

jamwaffles commented 5 years ago

@therealprof Thanks for reminding me about this. I've just bumped the version to 0.4.7 which is the latest at time of writing.

It would be great to get this PR merged! There are quite a few tasty features in newer e_g versions I'm sure people would like to use :slightly_smiling_face:.

therealprof commented 5 years ago

Indeed, I was looking into this driver yesterday to check whether there's a more ergonomic way to achieve https://github.com/junelife/rust-anywhere 😅

yuri91 commented 5 years ago

Hi!

I am not sure why but I missed any notification about this PR. I apologize for the delay, and I will gladly merge it later today when I will have a chance to look at it!

therealprof commented 5 years ago

Nice! Can get get a release, too, please? ;)

yuri91 commented 5 years ago

It is coming in a minute :)

yuri91 commented 5 years ago

There you go! Feel free to report problems/suggestions/PR in the future. I promise it won't take this long to reply next time!

jamwaffles commented 5 years ago

Awesome! No problem with the delay, we all have lives to live 🙂

therealprof commented 5 years ago

I have this running on a STM32F429 and I'm trying to come up with a good example.

@jamwaffles Would be great if you could take a look at black-and-white-ness of the simple iterator so we can get some color the easy (but ridiculously slow) way.

jamwaffles commented 5 years ago

@therealprof Are you referring to this issue? Did you get it fixed? I think it should be possible to just split the color variable into it's low and high bytes here and pass that to .draw_raw(). Still super slow, but I think that should be all you need to get colour?

therealprof commented 5 years ago

@jamwaffles Yes, that's the one.