search

yuri91 / ili9341-rs

A WIP, no_std, generic driver for the ILI9341 (and ILI9340C) TFT LCD display
Apache License 2.0
58 stars 50 forks source link

Bump embedded-hal to 1.0.0-alpha.9 #39

Closed chemicstry closed 2 years ago

yuri91 commented 2 years ago

thanks!

Paul-Vandell commented 2 years ago

@chemicstry @yuri91 Hey there, this change break the https://github.com/ivmarkov/rust-esp32-std-demo/pull/119 build. Can you help me to fixing it ?

chemicstry commented 2 years ago

@chemicstry @yuri91 Hey there, this change break the ivmarkov/rust-esp32-std-demo#119 build. Can you help me to fixing it ?

Embeded-hal 1.x versions of ili9341 are not published on crates.io so breaking changes are to be expected when using git dependencies. To lock git dependency version you should use rev specifier in Cargo.toml. Also in your case, I think you should commit Cargo.lock file, which would lock git dependency revisions. This file is not meant to be commited just for libraries.