search

yurikrupnik / angular-playground-full

0 stars 0 forks source link

Update dependency express-jwt to v6 [SECURITY] #7

Open renovate[bot] opened 3 years ago

renovate[bot] commented 3 years ago

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
express-jwt ^3.0.0 -> ^6.0.0 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2020-15084

Overview

Versions before and including 5.3.3, we are not enforcing the algorithms entry to be specified in the configuration. When algorithms is not specified in the configuration, with the combination of jwks-rsa, it may lead to authorization bypass.

Am I affected?

You are affected by this vulnerability if all of the following conditions apply:

You are using express-jwt AND You do not have algorithms configured in your express-jwt configuration. AND You are using libraries such as jwks-rsa as the secret.

How to fix that?

Specify algorithms in the express-jwt configuration. The following is an example of a proper configuration

const checkJwt = jwt({
  secret: jwksRsa.expressJwtSecret({
    rateLimit: true,
    jwksRequestsPerMinute: 5,
    jwksUri: `https://${DOMAIN}/.well-known/jwks.json`
  }),
  // Validate the audience and the issuer.
  audience: process.env.AUDIENCE,
  issuer: `https://${DOMAIN}/`,
  // restrict allowed algorithms
  algorithms: ['RS256']
});

Will this update impact my users?

The fix provided in patch will not affect your users if you specified the algorithms allowed. The patch now makes algorithms a required configuration.

Credit

IST Group

Release Notes

auth0/express-jwt (express-jwt) ### [`v6.0.0`](https://redirect.github.com/auth0/express-jwt/compare/v5.3.3...v6.0.0) [Compare Source](https://redirect.github.com/auth0/express-jwt/compare/v5.3.3...v6.0.0) ### [`v5.3.3`](https://redirect.github.com/auth0/express-jwt/compare/v5.3.2...v5.3.3) [Compare Source](https://redirect.github.com/auth0/express-jwt/compare/v5.3.2...v5.3.3) ### [`v5.3.2`](https://redirect.github.com/auth0/express-jwt/compare/v5.3.1...v5.3.2) [Compare Source](https://redirect.github.com/auth0/express-jwt/compare/v5.3.1...v5.3.2) ### [`v5.3.1`](https://redirect.github.com/auth0/express-jwt/compare/v5.3.0...v5.3.1) [Compare Source](https://redirect.github.com/auth0/express-jwt/compare/v5.3.0...v5.3.1) ### [`v5.3.0`](https://redirect.github.com/auth0/express-jwt/compare/v5.1.0...v5.3.0) [Compare Source](https://redirect.github.com/auth0/express-jwt/compare/v5.1.0...v5.3.0) ### [`v5.1.0`](https://redirect.github.com/auth0/express-jwt/compare/v5.0.0...v5.1.0) [Compare Source](https://redirect.github.com/auth0/express-jwt/compare/v5.0.0...v5.1.0) ### [`v5.0.0`](https://redirect.github.com/auth0/express-jwt/compare/v3.4.0...v5.0.0) [Compare Source](https://redirect.github.com/auth0/express-jwt/compare/v3.4.0...v5.0.0) ### [`v3.4.0`](https://redirect.github.com/auth0/express-jwt/compare/v3.3.0...v3.4.0) [Compare Source](https://redirect.github.com/auth0/express-jwt/compare/v3.3.0...v3.4.0) ### [`v3.3.0`](https://redirect.github.com/auth0/express-jwt/compare/v3.2.0...v3.3.0) [Compare Source](https://redirect.github.com/auth0/express-jwt/compare/v3.2.0...v3.3.0) ### [`v3.2.0`](https://redirect.github.com/auth0/express-jwt/compare/v3.1.0...v3.2.0) [Compare Source](https://redirect.github.com/auth0/express-jwt/compare/v3.1.0...v3.2.0) ### [`v3.1.0`](https://redirect.github.com/auth0/express-jwt/compare/v3.0.1...v3.1.0) [Compare Source](https://redirect.github.com/auth0/express-jwt/compare/v3.0.1...v3.1.0) ### [`v3.0.1`](https://redirect.github.com/auth0/express-jwt/compare/v3.0.0...v3.0.1) [Compare Source](https://redirect.github.com/auth0/express-jwt/compare/v3.0.0...v3.0.1)

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

This PR was generated by Mend Renovate. View the repository job log.

coderabbitai[bot] commented 5 months ago

[!IMPORTANT]

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.