search

yurishkuro / opentracing-tutorial

A collection of tutorials for the OpenTracing API
Apache License 2.0
1.57k stars 404 forks source link

C# implementation #21

Closed saschaholesch closed 6 years ago

saschaholesch commented 6 years ago

Added tutorial for C# implementation.

@yurishkuro Please review as discussed with @Falco20019

Falco20019 commented 6 years ago

Hm, I don’t have write access to the repo of @saschaholesch so I can’t fix it directly. Should have merged it to mine first and then did the PR to here... I will request him to give me collaborator state so that I can fix it later :)

Falco20019 commented 6 years ago

I think I addressed all remaining points. Please check if you are fine with the changes or if you want to have something else changed 👍

yurishkuro commented 6 years ago

🎈 🎈 🎈 🎈 🎈 🎈 🎈

yurishkuro commented 6 years ago

@saschaholesch @Falco20019 is there some command that can be run in the root directory to ensure that all dependencies are downloaded? I am giving an OT workshop at Velocity next Monday, want to mention the C# tutorial as well. For example, in the other tutorials you can run a build command once to download the dependencies, e.g.

cd opentracing-tutorial/nodejs
npm install
Falco20019 commented 6 years ago

It’s done automatically on build or you can do dotnet restore

yurishkuro commented 6 years ago

thanks, that's what I was looking for!