The program of [java lesson 3 solution] is defective.

[KNishikura]

The source of the following "Formatter.java" is a problem. If you look at the UI after execution, only three spans will be displayed. It is necessary to display 5 spans.

Formatter.java

    try (JaegerTracer tracer = Tracing.init("formatter")) {
        new Formatter(tracer).run(args);
    }

By implementing it as described in the Readme, you can see five spans.

Tracer tracer = Tracing.init("formatter"); new Formatter(tracer).run(args);

The same applies to "Publisher.java".

Sincerely yours, Kazuya Nishikura

[yurishkuro]

would you like to submit a merge request?

[KNishikura]

I do not know the essence of why this code is a problem.

[jpkrohling]

@KNishikura perhaps a good solution for now is to just change the Formatter class to be like the readme, so that it produces 5 spans?

[veterr]

I could do that pull request, but I get anauthorized message. Please authorise me (I am newbe to github, I input correct login and password to push to a new braunch "fixLesson03", but server rejects me)

[yurishkuro]

You don't need to push your branch to this repository. The standard way to do it on GitHub is to fork the repository and push a branch into your fork. GH is smart enough to create a PR from your branch in a fork to master in the main repo.

Just don't commit anything into master of your fork, it should always follow the mainline master.

[veterr]

Okey, did it

[yurishkuro]

do you mean PR #44?

[veterr]

Yes

[yurishkuro]

already addressed