Fix lesson 03 and 04 Formatter and Publisher to be like in readme, so…

yurishkuro / opentracing-tutorial

A collection of tutorials for the OpenTracing API

Apache License 2.0

1.57k stars 404 forks source link

Fix lesson 03 and 04 Formatter and Publisher to be like in readme, so… #44

Closed veterr closed 5 years ago

veterr commented 5 years ago

… that we could see 5 spans

yurishkuro commented 5 years ago

I do not understand how this change can result in more spans.
The current version using try-with-resource makes more sense, since it ensures the tracer is closed and the spans are flushed.

HodGreeley commented 5 years ago

Just tried this, and it works. I agree @yurishkuro, it doesn't seem like taking the Tracer instantiation out of the try-with-resources should matter, but it does. Must be some problem where closing the tracer immediately prevents the output from reaching jaeger?

veterr commented 5 years ago

Hi, Yury, I also don't understand, but somehow it helped. Looks like being inside of try catch block somehow influenced the tracers behaviour.

yurishkuro commented 5 years ago

already addressed