search

yurishkuro / opentracing-tutorial

A collection of tutorials for the OpenTracing API
Apache License 2.0
1.57k stars 407 forks source link

Use NewTracer() instead of deprecated New() #46

Closed justinclift closed 5 years ago

justinclift commented 5 years ago

New() seems to be deprecated, so might as well get people using NewTracer() instead from the very start. :smile:

yurishkuro commented 5 years ago

when you say "deprecated", are you using a different version of Jaeger lib than what is pinned in Gopkg.lock?

justinclift commented 5 years ago

From memory, doing it with v2.15.0. But I don't remember off hand, as I'm doing other non-Go stuff at the moment.

I'll confirm it later on today or tomorrow, as I'm presently in-process of rebuilding my development workstation from the ground up (changing machine). :smile:

justinclift commented 5 years ago

Just checked. I'd updated to version 2.15.0 in my local copy, to make sure the code/functions I'm learning with here are the same code as the real world production versions.

I'll update the Gopkg.toml & Gopkg.lock files in this PR to match (and manually verify the examples again), so everything lines up nicely. :smile:

justinclift commented 5 years ago

Sorry @yurishkuro, it looks like I won't be getting around to this after all.

(I'm closing out things atm, prior to deleting my GitHub account.)