search

yurishkuro / opentracing-tutorial

A collection of tutorials for the OpenTracing API
Apache License 2.0
1.57k stars 407 forks source link

Update the locked versions of all dependencies #48

Closed Omar-Khawaja closed 5 years ago

Omar-Khawaja commented 5 years ago

This ensures the locked versions of all dependencies get updated (especially important for the jaeger package being used in the tutorial if you're trying to move away from some of the deprecated methods).

yurishkuro commented 5 years ago

Upgrading of dependencies should not happen automatically when the user is trying to run the tutorial, it makes the whole thing non-repeatable.

yurishkuro commented 5 years ago

I am not able to dedicate enough time to keep these tutorials up to date with the latest versions of the dependent libraries. It is not the point of the tutorials to teach now to instantiate Jaeger tracer (this is what Jaeger documentation is for), but how to use the OpenTracing API (conceptually) to instrument the applications.

There is a PR (#46) to do the upgrade, but these changes are also difficult to review because while it looks good in the diff, it's hard to say if everything is covered, without redoing the tutorial step by step. I wish there was a more automated way to maintain that (open to suggestions).

Omar-Khawaja commented 5 years ago

That's definitely understandable. Thank you for the excellent tutorial!

justinclift commented 5 years ago

I wish there was a more automated way to maintain that (open to suggestions).

Yeah, it's a super common problem - especially for OSS projects - to keep the docs in line with the major releases. Seems to always be a manual process, needing someone to go through stuff as a "new user" would.

In my instance, I really am a new user (#46). :smile: