search

yurishkuro / opentracing-tutorial

A collection of tutorials for the OpenTracing API
Apache License 2.0
1.57k stars 404 forks source link

update jaeger python client version and move it to jaegertracing repo #68

Closed Amiedeep closed 4 years ago

Amiedeep commented 4 years ago

This pull request updates jaeger python client repository to jaegertracing and bump its version to 4.3.0.

This will resolve marking spans as erroneous issue when either of the publisher or the formatter are down in exercise03, exercise04.

yurishkuro commented 4 years ago

since we don't have proper CI for this code, were you able to test this change to confirm that it works and fixes the issue with error state?

Amiedeep commented 4 years ago

Yes, It worked. I would suggest you to double check and run one exercise.