search

yurishkuro / opentracing-tutorial

A collection of tutorials for the OpenTracing API
Apache License 2.0
1.57k stars 407 forks source link

FlaskTracer vs opentracing.tracer #8

Open ror6ax opened 6 years ago

ror6ax commented 6 years ago

https://github.com/yurishkuro/opentracing-tutorial/blob/master/python/lesson03/solution/formatter.py#L12 fails if tracer is FlaskTracer with 'FlaskTracer' object has no attribute '_noop_span_context'. Could we add some distinction between the two tracer objects?

yurishkuro commented 6 years ago

sorry, I don't follow. The line you point to is a standard OpenTracing API usage, it knows nothing about "FlaskTracer" or "_noop_span_context".