yurisuika / Raised

Raises the hotbar so the selector is not cut off!
GNU Lesser General Public License v3.0
17 stars 5 forks source link

Custom Hotbar Selector texture not being used #80

Closed Obscure2020 closed 8 months ago

Obscure2020 commented 8 months ago

I use the resource pack VanillaXBR, as well as a Fabric mod stack that includes Raised. Just today, I noticed that Raised is not actually using the hotbar_selection.png texture provided by the resource pack.

I am using Raised v3.1.0.

With Raised:

2023-12-27_15 12 47

Without Raised:

2023-12-27_15 20 18

Is this a Raised bug, or do we need to specify the texture in a different form / with a different name / in a different place in the resource pack to make Raised use it?

Obscure2020 commented 8 months ago

And if we do need to specify the texture in a different place, what is the exact path within the resource pack where we should add the texture? This specific information should be publicly documented, but it does not appear to be listed in the GitHub Readme, the Modrinth Readme, or the GitHub Wiki.

yurisuika commented 8 months ago

This is only for 1.20.2+ because Mojang butchered the selector further when they split up the atlas and cut off the selector now in texture not just code. While they did match the selector's code to render 23px in height as for what is shown on the vanilla Java screen (before it was cut off at 22px from a total of 24px), the new split GUI sprites use their own method that stretches the entire texture; this forces Raised to have to have a new asset that is not cut off in texture because such a whole texture no longer exists in the vanilla assets.

You'll find the same asset under the the same directory just under the raised namespace that should be a 24px tall (at vanilla scaling) image instead of a 23px tall one. You will need to provide your own fixed asset for 1.20.2+ for the selector.

Obscure2020 commented 8 months ago

So the path is assets/raised/textures/gui/sprites/hud/hotbar_selection.png.

Thanks for the info.\ Cheers!