search

yurisuika / Raised

Raises the hotbar so the selector is not cut off!
GNU Lesser General Public License v3.0
17 stars 5 forks source link

Banner patterns in the Loom GUI don't load when installed alongside PuzzlesLib #83

Closed ildiem closed 5 months ago

ildiem commented 6 months ago

(Running Minecraft 1.20.4 with Fabric 0.15.6)

When a client has both PuzzlesLib and Raised installed, opening a Loom and trying to apply a banner pattern will load all of the pattern options without their patterns (the buttons still work). Keeping PuzzlesLib enabled and Raised disabled removes the problem, as does keeping Raised enabled and PuzzlesLib disabled, so I'm not sure which mod is causing the issue.

Screenshot 2024-03-06 at 7 34 48 PM

The only other mods installed are Fabric API (0.96.4+1.20.4) and Forge Config API Port (20.4.3).

Here is my latest.log file.

yurisuika commented 5 months ago

I've noted this only occurs on the Fabric version. As well, it seems that it is causing Raised's chat offset to translate its own options screen. Surely this is some mixin conflict.

yurisuika commented 5 months ago

The loom issue seems to be stemmed by Raised translating the z-index of ChatHud's render within InGameHud's render by 300 to fix the chat being under the hotbar itemstacks when the HUD is translated to a spot where it would overlap, but this doesn't explain what is occurring with the options screen. I will have to look into what Puzzles is doing to see why both of these are being affected by changes to the chat.

yurisuika commented 5 months ago

Alright I've solved it, for each translated element it needs to push and translate and pop the matrixstack instead of translating and then de-translating afterwards. This solves both problems.