search

yurisuika / Zehn

A Steam skin based on Windows 10's Metro/Fluent transitional design language.
71 stars 0 forks source link

Integration Conflicts #8

Closed shdwmtr closed 6 months ago

shdwmtr commented 6 months ago

no longer works with millennium.

Reason:

The live and static version in this case doesn't really serve a purpose as of right now considering SFP will be most likely be adopting millenniums API, or some other alternative similar, so having a live version causes conflicts.

if you like the live version, just put it in a live folder and keep the static in the root folder like it was previously. This way it will work with Millennium and SFP when the updates come.

yurisuika commented 6 months ago

I've been wanting to move to a release format for a while now instead of relying on a source archive, so the ZIP is not crammed with other garbage from the repo. This is ever more urgent now that it seems I have to host preview assets here (but that is another tale don't need to get into now).

Well the reason why the master and live branches were merged into one was mainly to keep the source for the release with its entirety and only have to run the new action once and ensure that the live version which doesn't need to be updated constantly to be included in the release so it isn't buried somewhere far back in the releases which sort of defeats the purpose of having them in the first place if the user cannot find the archive. Having them split will overwrite the source from one or the other branch when the action is ran, which I am not happy with, especially if the live version is pushed latest. I don't want the versions to be on different repos or have a mixed hierarchy.

I don't see how a live version causes conflicts? All it does is reference what is hosted on GitHub Pages.

I have moved them separately for now until I can come up with a different solution.

shdwmtr commented 6 months ago

The best way to handle your idea is it use branches, as this isn't the best way to come about it.

Millennium and soon to be SFP, relies on your skin.json being in the root directory of the GitHub repository in order to function. The Millennium API does not download releases, it downloads the latest source code of the branch. This means when it downloads and extracts it wont be able to find the skin.json information as its nested inside the static folder.

shdwmtr commented 6 months ago

It seems you've already got the jest with the branches though; I just noticed.

Thanks for fixing it, 100's of people using your theme were disappointed it disappeared. Cheers.