search

yuriyoleynikov / YoTennis

Application for Tennis stats.
0 stars 0 forks source link

Fix names in MatchState enum #5

Closed Igorbek closed 7 years ago

Igorbek commented 7 years ago

From my comment in #2:

" Ok, I meant you would rename BeginTiebreak to BeginningTiebreak. Now you still have inconsistency: verb + object: BeginGame, BeginTiebreak gerund [+ object]: Drawing, PlayingGame, ChangingSides, PlayingTiebreak, ChangingSidesOnTiebreak adjective: Completed adjective phrase: NotStarted

From the language perspective, both gerunds and adjectives are adjective phrases. So only form with a verb is inconsistent. Note the proper spelling: Beginning. "

Please fix and create a PR

yuriyoleynikov commented 7 years ago

Closed